Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

Backport issue 426 / PR 429 to branch 2.2 #611

Merged
merged 1 commit into from
Nov 23, 2013
Merged

Backport issue 426 / PR 429 to branch 2.2 #611

merged 1 commit into from
Nov 23, 2013

Conversation

jdespatis
Copy link
Contributor

Yaml config files into app/config are not valid

This issue has already been reported one year ago with issue #426, and has been fixed thanks to PR #429
However, it seems that this PR has been merged into branch 2.1, and not backported into master

Therefore this bug still exists in master, 2.2, 2.3 and 2.4

Here is a PR to merge into branch 2.2 (and it would need a backport into master, 2.3 and 2.4 ?, and maybe a new tag for each)

fabpot added a commit that referenced this pull request Nov 23, 2013
This PR was merged into the 2.2 branch.

Discussion
----------

Backport issue 426 / PR 429 to branch 2.2

Yaml config files into app/config are not valid

This issue has already been reported one year ago with issue #426, and has been fixed thanks to PR #429
However, it seems that this PR has been merged into branch 2.1, and not backported into master

Therefore this bug still exists in master, 2.2, 2.3 and 2.4

Here is a PR to merge into branch 2.2 (and it would need a backport into master, 2.3 and 2.4 ?, and maybe a new tag for each)

Commits
-------

ead925b Backport issue 426 / PR 429 to branch 2.2
@fabpot fabpot merged commit ead925b into symfony:2.2 Nov 23, 2013
@jdespatis jdespatis deleted the valid-yaml-2.2 branch November 23, 2013 23:26
@jdespatis
Copy link
Contributor Author

@fabpot , 2 more questions:
1/ this bug has been merged into all branches, except 2.4, is it a forget or normal because next 2.4 beta/rc will be created from master ?
2/ Would you mind releasing a new tag for stable branches 2.2, and 2.3 ? This bug being quite blocking for one that uses a (strict) yaml parser

@fabpot
Copy link
Member

fabpot commented Nov 24, 2013

@jdespatis

1/ Just an oversight on my side (fixed now)
2/ Sure, next time we release a Symfony 2.2.x and 2.3.x versions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants